Hard to say whether he would have become president with another vP pick. Palin had great appeal to many Republicans, in much the same convoluted way Trump had appeal.That is something, amazing. If he had not let himself be saddled with Palin, I have no doubt he would have been President, and probably a good one or at least average or better.
I would see an equal possibility that McCain could have done worse.