I dont have a problem with the President addressing school children. If he did anything partisan it would be a perfect opportunity to show kids how ridiculous he is being. If he doesnt, then no harm no foul.
The Lesson plan follow up was a bit more controversial. making kids write about what they can do to help Obama.
That was beyond controversial - it was a bit creepy...